Ticket #1291 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Hide palette group before immediate popup

Reported by: alsroot Owned by: erikos
Priority: Unspecified by Maintainer Milestone: 0.86
Component: sugar-toolkit Version: Git as of bugdate
Severity: Unspecified Keywords: r!
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Otherwise it could look pretty ugly, several palettes at the same time.

Attachments

sugar-1291.patch Download (0.9 KB) - added by alsroot 4 years ago.
sugar-1291.2.patch Download (1.3 KB) - added by alsroot 4 years ago.

Change History

Changed 4 years ago by alsroot

  Changed 4 years ago by alsroot

  • owner changed from tomeu to erikos
  • component changed from sugar to sugar-toolkit

  Changed 4 years ago by alsroot

patch was updated to take into account #1310

Changed 4 years ago by alsroot

follow-up: ↓ 4   Changed 4 years ago by tomeu

  • keywords r! added; r? removed

Unsure about:

 	376	        if self._invoker is None: 
 	377	            return

Should we be setting self._up = True even if we have no invoker?

in reply to: ↑ 3   Changed 4 years ago by alsroot

Replying to tomeu:

Unsure about:

{{{
376 if self._invoker is None:
377 return
}}}

Should we be setting self._up = True even if we have no invoker?

yeah, wasn't sure about it

  Changed 4 years ago by alsroot

  • status changed from new to closed
  • resolution set to fixed

 http://git.sugarlabs.org/projects/sugar-toolkit/repos/mainline/commits/868c9293ac451db0e72c227d58534b60eb01938a

Note: See TracTickets for help on using tickets.