Ticket #1285 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Visual artefacts on highlighted frame buttons

Reported by: alsroot Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: 0.86
Component: sugar Version: Git as of bugdate
Severity: Unspecified Keywords: r?
Cc: erikos, garycmartin Distribution/OS: Unspecified
Bug Status: Needinfo

Description


Attachments

Untitled.png Download (12.2 KB) - added by alsroot 4 years ago.
sugar-1285.patch Download (0.8 KB) - added by alsroot 4 years ago.
sugar-1285-hidden-frame-buttons.patch Download (0.9 KB) - added by alsroot 4 years ago.

Change History

Changed 4 years ago by alsroot

Changed 4 years ago by alsroot

  • cc erikos, garycmartin added

The problem is, FrameWindow sets set_override_redirect(True), so PaletteWindow can't be over FrameWindow.

So, we need to disable set_override_redirect for FrameWindow or enable it for PaletteWindow(which could brake heavy palettes if activity developper assumes that palette is a regular window).

Changed 4 years ago by alsroot

  • status_field changed from Unconfirmed to Needinfo

Changed 4 years ago by alsroot

Changed 4 years ago by alsroot

  • keywords r? added

I guess less invasive(at least for 0.86) would be just removing set_override_redirect(True) from FrameWindow.

Changed 4 years ago by alsroot

Changed 4 years ago by alsroot

Previous patch intended to fix  http://dev.sugarlabs.org/ticket/1060#comment:9 issue, not sure how it works but w/ this patch attached I can't reproduce mentioned issue.

Changed 4 years ago by alsroot

  • status changed from new to closed
  • resolution set to fixed

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/6a79442e280c80736fd7c950b0195686632a22f8
 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/0ab0e8ec79a42664bb2ba80505991c4ee893e9a6

Note: See TracTickets for help on using tickets.