Process non-ds object in the right way in Journal

[alsroot]

For 0.86 edit widgets could be just insensitive

[tomeu]

The patch looks good, just a couple of questions:

374	 	def find(query, page_size): 
 	374	def find(query_, page_size): 

Why do we need to make this change?

        mountpoints = metadata.get('mountpoints')

When do we have a 'mountpoints' property? Didn't knew about it.

[alsroot]

Replying to tomeu:

The patch looks good, just a couple of questions:

{{{
374 def find(query, page_size):
374 def find(query_, page_size):
}}}

because it changes query argument(by poping 'mountpoints'), so next invoking of ListModel() in listview.py:287 will not contain 'mountpoints'

Why do we need to make this change?

{{{
mountpoints = metadata.get('mountpoints')
}}}

When do we have a 'mountpoints' property? Didn't knew about it.

model.is_editable() is used for query as well(when we don't have any row, see the patch)

[tomeu]

Looks good to me, though I would do:

is_editable = self._query.get('mountpoints', '') == '/'
self.cell_title.props.editable = is_editable

instead of

315             is_editable = False 
316	        mountpoints = self._query.get('mountpoints') 
317	        if mountpoints is not None and len(mountpoints): 
318	            is_editable = mountpoints[0] == '/' 
319	        self.cell_title.props.editable = is_editable 

[alsroot]

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/549be18e280fd24cd6c2b16f21c144de4d6fe415

[alsroot]

Related non-ds issues: #1411, #1415

[alsroot]

Reopen ticket to have more essential behaviour in 0.88

[garycmartin]

Did this make it in to 0.88? Perhaps push back additional work (if they are not bug fixes) to 0.90?

[alsroot]

I guess it could be closed since there is #1636 which implements RW for non-ds objects.