sugar-datastore not stopped on logout (+automatic re-login)

[sascha_silbe]

After choosing "Logout" sugar-datastore keeps running, so when the next Sugar session starts up (which is immediately afterwards on DebXO) two sugar-datastore instances are running, both trying to write the Xapian index and both failing. We should make sure sugar-datastore has stopped (wait for DBus signal Stopped) before exiting sugar-session.

On unclean shutdowns (e.g. zapping the X server with Alt+Ctrl+BS) the situation is similar, though it's less clear how to handle that case (as the old instance cannot be reached via DBus from the new session - maybe use a PID file?).

[sascha_silbe]

old session: datastore.log

[sascha_silbe]

old session: shell.log

[sascha_silbe]

new session: datastore.log

[sascha_silbe]

new session: shell.log

[tomeu]

The DBus session should be closed when the sugar-session client finishes, and the DS process should exit when the dbus connection closes. We should see why this isn't working.

[sascha_silbe]

I've just discovered another reason for this to happen: My ~/.xsession (created a long time ago) used dbus-launch without --exit-with-session (probably because I didn't know this option). I need to investigate why I put the dbus-launch there / whether it's still necessary (since dbus support is activated in /etc/X11/Xsession.options).

[tomeu]

Ok, so my understanding of the issue is that we need to make the shell process exit only after the DS has disappeared from the bus by either listening to the NameOwnerChanged signal or the less standard Closed signal in the Datastore iface as Sascha suggests. I'm not sure which one is best.