Ticket #1253 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Activitiestray download palettes does not allow accepting a file of unrecognised MIME type

Reported by: garycmartin Owned by: tomeu
Priority: Urgent Milestone: 0.86
Component: sugar Version: 0.84.x
Severity: Unspecified Keywords:
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

Journal "send to -> friend" of an item that the receiver does not yet have an activity that supports its MIME type, prevents the remote user from accepting the file transfer (the accept button does nothing when you click). Example: Trying to transfer some application/x-physics-activity physics simulations over to another laptop before you have installed Physics-3.xo. Expectation is that you would receive application/x-physics-activity files to your Journal and then later when you install Physics-3.xo (or some other tool that accepted that MIME type) the files could be started correctly.

Attachments

download_palette_when_mime_file_type_is_not_yet_known.png Download (37.2 KB) - added by garycmartin 4 years ago.
Here's a screenshot, note that the MIME type appears in full if you Sugar doesn't yet have an activity that can deal with it (if you do it just says "physics activity")

Change History

  Changed 4 years ago by garycmartin

  • version changed from Unspecified to 0.84.x

Spotted this case in both 0.84.x and latest 0.85.x

  Changed 4 years ago by garycmartin

Here's the trace back:

Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/jarabe/frame/activitiestray.py", line 772, in __accept_activate_cb
    prefix=self._sanitize(self.file_transfer.title))
  File "/usr/lib/python2.6/tempfile.py", line 293, in mkstemp
    return _mkstemp_inner(dir, prefix, suffix, flags)
  File "/usr/lib/python2.6/tempfile.py", line 226, in _mkstemp_inner
    file = _os.path.join(dir, pre + name + suf)
TypeError: coercing to Unicode: need string or buffer, NoneType found

Changed 4 years ago by garycmartin

Here's a screenshot, note that the MIME type appears in full if you Sugar doesn't yet have an activity that can deal with it (if you do it just says "physics activity")

  Changed 4 years ago by tomeu

  • priority changed from Unspecified by Maintainer to Urgent

  Changed 4 years ago by tomeu

  • status changed from new to closed
  • resolution set to fixed

Fixed by  http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/2fa681b8 r+'ed by Aleksey in #sugar

|TestCase|
- From the journal, send a TurtleArt entry to a friend
- From the other laptop accept it
- Check that the entry is transferred

follow-up: ↓ 6   Changed 4 years ago by walter

Just to be clear, send still only works under a Salut (local), not Gabble (server) connection?

So the test case should probably go:

* Connect to your Sugar neighborhood through a local connect by making sure your Jabber Server preference is not set (blank) on the Network page of the Control Panel
* From the journal, send a TurtleArt entry to a friend (who is also connected locally)
* From the friend's Sugar, accept the transfer
* Check that the entry is transferred by launching it (click on the new entry in the Journal)

in reply to: ↑ 5   Changed 4 years ago by garycmartin

Replying to walter:

Just to be clear, send still only works under a Salut (local), not Gabble (server) connection?

No. Works for both Salut and Gabble. If it's broken, it's must have broken recently, I haven't tested this in the last week or two.

  Changed 4 years ago by walter

Great. (Just read about it in the 0.86 Release Notes.) Mea culpa.

Note: See TracTickets for help on using tickets.