Journal list view: jumping back to first page when popping up a palette

[sascha_silbe]

The Journal list view jumps back to the first page when opening a palette, making it impossible to resume old entries.
The attached patch fixes that by refreshing the list only on change from fully-obscured to visible, not on every minor visibility change.

[sascha_silbe]

fix Journal list view jumping back to first page on showing a Palette

[tomeu]

Thanks, please push.

[alsroot]

 http://git.sugarlabs.org/projects/sugar/repos/thumbs-non-ds/commits/3bc29a944da05b87718ceda188ebd2f779c103b0
could be more relyable, since we have model all time uptodate

[alsroot]

e.g. in case of changing entries w/o opening details view

[alsroot]

related fix
 http://git.sugarlabs.org/projects/sugar/repos/thumbs-non-ds/commits/05f9ed60c895b8adaac8ee419ff624e576c68674
Discrad cache while changing resultset #1235

[alsroot]

last three comments are obsoleted

[alsroot]

last patch is adapted version of previous two commit links

[alsroot]

last patch was rewrote according to irc discussion

[alsroot]

at the end another approach was chosen - just change vadjustment value
 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/18b089a07f68aa669d49ebdac726e5d71ab9985c

the bad thing with this way is after requery list view loses focus highliting(e.g. select row, after clicking on Favorite icon for this row it losses focus). One of possible decision is change focus color(for shell process not in gtkrc)

so, if its not ok with losing focus, please reopen ticket

[tomeu]

Sounds good, thanks.

[alsroot]

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/12f562c59323a008ed16a306f419ab6f642153e1
 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/8310ee90abc33a8d5db05e8bdb3459186cf02699

[erikos]

Do the same for the activities list:  http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/975a3bdbcc0f8e4e8efc41357109e6c8cf6173d0

[alsroot]

Replying to alsroot:

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/12f562c59323a008ed16a306f419ab6f642153e1

This commit leads to flickering while hide/show invoking in development ubuntu and mandriva repos, w/o this commit Journal doesn't flickering like in gentoo(just scrollbars movements).

So, in my mind we have odd consequences of tying to particular gtk version behaviour.

[alsroot]

Replying to alsroot:

Replying to alsroot:

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/12f562c59323a008ed16a306f419ab6f642153e1

This commit leads to flickering while hide/show invoking in development ubuntu and mandriva repos, w/o this commit Journal doesn't flickering like in gentoo(just scrollbars movements).

So, in my mind we have odd consequences of tying to particular gtk version behaviour.

|TestCase|
* have move then one page of entries in Jorunal
* scroll to top
* scroll to one row down
* chage Favorite icon
* in last ubuntu/mandriva its flickering

[alsroot]

Its still not ideal, but it works w/o glitches in all of my environments.

And I guess we need to rewrite listview code in 0.88.

[tomeu]

Replying to alsroot:

And I guess we need to rewrite listview code in 0.88.

Well, mostly the model I guess, so we don't reset it. It may help if the journal accesses directly the xapian index, instead of going through the DS.

[alsroot]

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/14273483f86dea408da600998507c676db51f02a