Ticket #1210 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

let the logger do the formatting

Reported by: sascha_silbe Owned by: sascha_silbe
Priority: Unspecified by Maintainer Milestone: 0.86
Component: sugar Version: Unspecified
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: New

Description

With the attached patch we delegate the string formatting to the logger instead of doing it ourselves.
Advantages:
a) It's more robust: Constructs like 'debug("foo %r bar" % x)' are quite common in our code and will break if x is a tuple. 'debug("foo %r bar", x)' will work regardless of the type of x.
b) formatting only happens if we actually log something.

I haven't measured the impact of b) because a) is much more important to me (happened a lot of times during the object_id => (tree_id, version_id) conversion). At least one project has asked for pylint to flag these occurences and gave performance as a reason for the change, though (so they mave have measured it).

Attachments

0001-let-the-logger-do-the-formatting.patch Download (59.8 KB) - added by sascha_silbe 4 years ago.
let the logger do the formatting

Change History

Changed 4 years ago by sascha_silbe

let the logger do the formatting

Changed 4 years ago by erikos

  • milestone changed from Unspecified by Release Team to 0.86

Changed 4 years ago by tomeu

  • keywords r+ added; r? removed
  • owner changed from tomeu to sascha_silbe
  • status changed from new to assigned

Looks good, we should push these changes early in the release cycle, though. Please push, thanks!

Changed 4 years ago by sascha_silbe

  • status changed from assigned to closed
  • resolution set to fixed

Pushed, thanks!

Note: See TracTickets for help on using tickets.