Ticket #1198 (closed task: fixed)

Opened 4 years ago

Last modified 3 years ago

use sugar.datastore.* instead of direct DBus access

Reported by: sascha_silbe Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: 0.88
Component: sugar Version: Git as of bugdate
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: New

Description

As discussed on IRC this patch replaces direct datastore DBus API access with calls to sugar.datastore.*. This is the sugar part of the patch, see #1197 for the sugar-toolkit part it depends on.

Attachments

sugar-0001-use-sugar.datastore.datastore-or-at-least-sugar.data.patch Download (21.0 KB) - added by sascha_silbe 4 years ago.
use sugar.datastore.* instead of direct DBus access
0001-use-sugar.datastore.-instead-of-direct-DBus-access.patch Download (21.2 KB) - added by sascha_silbe 4 years ago.
use sugar.datastore.* instead of direct DBus access (updated)

Change History

Changed 4 years ago by sascha_silbe

use sugar.datastore.* instead of direct DBus access

Changed 4 years ago by sascha_silbe

use sugar.datastore.* instead of direct DBus access (updated)

Changed 4 years ago by sascha_silbe

With the updated patch file transfer works as well (in both directions, including cancelling/declining transfer and watching the transferring file in the Journal details view).
It requires #1201, though.

Changed 4 years ago by tomeu

  • keywords r! added; r? removed

As discussed in IRC, I would prefer to fix bugs at this point of the release cycle. This is a big change that is likely to introduce new bugs and doesn't have a strong enough need AFAICS.

Changed 4 years ago by tomeu

  • milestone changed from 0.86 to 0.88

Changed 3 years ago by erikos

  • keywords r? added; r! removed

Changed 3 years ago by erikos

  • keywords r+ added; r? removed
  • status changed from new to closed
  • resolution set to fixed

reviewed and discussed on irc:  http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/118287969c7b95c80254c960984235bc2f1a312d

Note: See TracTickets for help on using tickets.