Ticket #1197 (closed task: fixed)

Opened 4 years ago

Last modified 3 years ago

use sugar.datastore.* instead of direct DBus access

Reported by: sascha_silbe Owned by: erikos
Priority: Unspecified by Maintainer Milestone: 0.88
Component: sugar-toolkit Version: Git as of bugdate
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: New

Description

As discussed on IRC this patch replaces direct datastore DBus API access with calls to sugar.datastore.*. This is the sugar-toolkit part of the patch.

Attachments

sugar-toolkit-0001-use-sugar.datastore.datastore-or-at-least-sugar.data.patch Download (8.5 KB) - added by sascha_silbe 4 years ago.
use sugar.datastore.* instead of direct DBus access
0001-use-sugar.datastore.-instead-of-direct-DBus-access.patch Download (8.4 KB) - added by sascha_silbe 4 years ago.
use sugar.datastore.* instead of direct DBus access (updated)

Change History

Changed 4 years ago by sascha_silbe

use sugar.datastore.* instead of direct DBus access

Changed 4 years ago by sascha_silbe

See #1198 for the sugar part of this patch.

Changed 4 years ago by sascha_silbe

use sugar.datastore.* instead of direct DBus access (updated)

Changed 4 years ago by tomeu

As discussed in IRC, I would prefer to fix bugs at this point of the release cycle. This is a big change that is likely to introduce new bugs and doesn't have a strong enough need AFAICS.

Changed 4 years ago by erikos

  • milestone changed from 0.86 to 0.88

ok, let's defer this one. Thanks for taking a look tomeu.

Changed 3 years ago by tomeu

I think something like this is a worthy cleanup.

Changed 3 years ago by erikos

  • keywords r+ added; r? removed
  • status changed from new to closed
  • resolution set to fixed

reviewed and discussed on irc:  http://git.sugarlabs.org/projects/sugar-toolkit/repos/mainline/commits/e1d4afe13e3b49f01083a00ca4b83cc4011829d8

Note: See TracTickets for help on using tickets.