Ticket #1192 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Object chooser remains shown after activity has been closed

Reported by: sascha_silbe Owned by: alsroot
Priority: Unspecified by Maintainer Milestone: 0.86
Component: Browse Version: Git as of bugdate
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: New

Description

Steps to reproduce:
1. Open Browse
2. Navigate to some page that has a file upload form.
3. Click "Browse" to open Journal object picker.
4. Close the activity without closing the object picker first.

What I expected: Close the object picker as well.

What happened: The object picker is shown on top of the home view.

Attachments

sugar-1192.patch Download (1.5 KB) - added by alsroot 4 years ago.

Change History

Changed 4 years ago by alsroot

  • owner changed from tomeu to erikos
  • component changed from sugar to Browse

looks like its a Browse specific issue, in other activities it works fine if parent parameter was passed to ObjectChooser's ctor

Changed 4 years ago by alsroot

  • keywords r? added

Changed 4 years ago by tomeu

  • keywords r! added; r? removed

The problem with this is that several instances of the browse activity can run in the same process. That's why the parent var was in the instance and not in the class and why we have hulahop.get_view_for_window().

Changed 4 years ago by alsroot

Changed 4 years ago by alsroot

  • keywords r? added; r! removed

Changed 4 years ago by tomeu

  • keywords r+ added; r? removed
  • owner changed from erikos to alsroot
  • status changed from new to assigned

Looks great, thanks!

Changed 4 years ago by erikos

  • status changed from assigned to closed
  • resolution set to fixed

Pushed, thanks for the patch.

commit 51863250cdea13209a8f2a75eacb8c54227a4465

Note: See TracTickets for help on using tickets.