Ticket #1176 (closed defect: fixed)

Opened 4 years ago

Last modified 13 days ago

Upgrade activities that were installed from bundles

Reported by: alsroot Owned by: tomeu
Priority: Unspecified by Maintainer Milestone:
Component: sugar Version: 0.84.x
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

This patch intended only for 0.84

Attachments

sugar-1176.patch Download (1.5 KB) - added by alsroot 4 years ago.

Change History

Changed 4 years ago by alsroot

  Changed 4 years ago by alsroot

  • cc r? removed
  • keywords r? added

follow-up: ↓ 3   Changed 4 years ago by sascha_silbe

Looks like a dupe of #1042.

in reply to: ↑ 2   Changed 4 years ago by alsroot

Replying to sascha_silbe:

Looks like a dupe of #1042.

yup, thats why thats patch only for 0.84, in 0.86 it could be fixed in other way

  Changed 4 years ago by tomeu

  • keywords r! added; r? removed

How does this patch helps it? AFAICS the problem is that we are raising AlreadyInstalledException when updating, cannot see what has to do where the existing bundle was installed.

follow-up: ↓ 7   Changed 4 years ago by alsroot

in existed 0.84 code AlreadyInstalledException will be raised in any case(if we have the same bundle_id despite of the current version)

attached patch do that only for preinstalled(not in ~/Activities) activities, for .xo activities it just pass though and compare versions to raise AlreadyInstalledException

  Changed 4 years ago by alsroot

  • milestone changed from Unspecified by Release Team to 0.84

in reply to: ↑ 5   Changed 4 years ago by tomeu

  • keywords r+ added; r! removed
  • status changed from new to closed
  • resolution set to fixed

Replying to alsroot:

in existed 0.84 code AlreadyInstalledException will be raised in any case(if we have the same bundle_id despite of the current version)

attached patch do that only for preinstalled(not in ~/Activities) activities, for .xo activities it just pass though and compare versions to raise AlreadyInstalledException

ok, got it now, thanks. Wish the naming of those funcs was clearer, but as this is only for 0.84...

  Changed 13 days ago by godiard

  • milestone 0.84 deleted

Milestone 0.84 deleted

Note: See TracTickets for help on using tickets.