Ticket #1098 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

Fix .xoj support

Reported by: alsroot Owned by: tomeu
Priority: Unspecified by Maintainer Milestone: 0.88
Component: sugar Version: 0.84.x
Severity: Unspecified Keywords: r+
Cc: Distribution/OS: Unspecified
Bug Status: Unconfirmed

Description

At present sugar fails on uploading .xoj to Journal

Attachments

sugar-1098 Download (3.7 KB) - added by alsroot 4 years ago.
0001-journalentrybundle.install-use-install_dir-param.patch Download (1.3 KB) - added by martin.langhoff 4 years ago.
0001-Clean-up-some-.xoj-registry-code-1098.patch Download (1.3 KB) - added by alsroot 3 years ago.

Change History

  Changed 4 years ago by alsroot

  • owner changed from tomeu to alsroot
  • status changed from new to assigned

Changed 4 years ago by alsroot

  Changed 4 years ago by alsroot

  • keywords r? added
  • owner changed from alsroot to tomeu

  Changed 4 years ago by alsroot

  • milestone changed from Unspecified by Release Team to 0.84

  Changed 4 years ago by tomeu

  • keywords r+ added; r? removed
  • status changed from assigned to closed
  • resolution set to fixed

Pushed to both 0.84 and HEAD. Thanks!

Changed 4 years ago by martin.langhoff

follow-up: ↓ 6   Changed 4 years ago by martin.langhoff

  • status changed from closed to reopened
  • resolution fixed deleted

Debugging this problem on 0.84.5 (the fix was in 0.84.6) I wrote a slightly different patch.

Reviewing Erikos' patch, now that I've found this bugreport :-), it is much better and cleaner than mine, except for a minor cleanup (attached).

So I am reopening for this minor cleanup (which is not worth a separate bug really). Hope that's a reasonable flow.

in reply to: ↑ 5   Changed 3 years ago by tomeu

Replying to martin.langhoff:

Debugging this problem on 0.84.5 (the fix was in 0.84.6) I wrote a slightly different patch.

Reviewing Erikos' patch, now that I've found this bugreport :-), it is much better and cleaner than mine, except for a minor cleanup (attached).

So I am reopening for this minor cleanup (which is not worth a separate bug really). Hope that's a reasonable flow.

Sorry, not sure what is being requested here, where is Erikos' patch?

  Changed 3 years ago by erikos

  • keywords r+, olpc-0.84 added; r+ removed

Changed 3 years ago by alsroot

  Changed 3 years ago by alsroot

  • milestone changed from 0.84 to 0.88

We have a mess with bundle types related code for a long time, some proposals poped up several times but the problem was that it happened just before releasing new sugar (like now:).

Last patch is cleaning some code, I guess it shouldn't introduce regressions since we already had special install() declaration for .xoj, so make it more special shouldn't be a problem.

  Changed 3 years ago by alsroot

  • status changed from reopened to closed
  • resolution set to fixed

 http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/fb81d3a51f29b0bf71843bb5540e508b6d480c25

so, in martin.langhoff's patch, install()'s argument should not be used at all

  Changed 3 years ago by sayamindu

  • keywords olpc-0.84+ added; olpc-0.84 removed

Cherry-picked to 0.84

  Changed 3 years ago by sayamindu

  • keywords r+ added; r+, olpc-0.84+ removed
Note: See TracTickets for help on using tickets.